Better handling of negative elements in enum #40679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
changed the title
ghiculescu
force-pushed
the
negative-enum-warning
branch
from
3d74bce
to
9d35f5d
Compare
ghiculescu
force-pushed
the
negative-enum-warning
branch
from
9d35f5d
to
e1a0a8e
Compare
rafaelfranca
reviewed
Dec 8, 2020
| "Book" | ||
| end | ||
| silence_warnings do | ||
| enum status: [:not_sent, :sent] |
There was a problem hiding this comment.
Missing a test with _scopes: false since we should not show the warning if that option is passed.
There was a problem hiding this comment.
Good pickup. Added a new test + this fix.
Fixes rails#39065. Adds a more descriptive warning, and logs it less often.
ghiculescu
force-pushed
the
negative-enum-warning
branch
from
e1a0a8e
to
6f9c639
Compare
rafaelfranca
added a commit
that referenced
this pull request
Dec 9, 2020
Better handling of negative elements in enum
rafaelfranca
added a commit
that referenced
this pull request
Dec 9, 2020
Better handling of negative elements in enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39065; fixes a warning added in #36380 that fires a bit too often. Adds a more descriptive warning, and logs it only when there's actually a conflict.
An example of where this is annoying is in our app:
Results in this warning every time the app boots:
An enum element in MobileDeviceToken uses the prefix 'not_'. This will cause a conflict with auto generated negative scopes.Even though there isn't actually anything we need to change.