Let AS::SafeBuffer#[] and * return value be an instance of SafeBuffer in Ruby 3.0 #40663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in Ruby 3 Ruby 3 introduces an incompatibility that String methods return String instances when called on a subclass instance. https://bugs.ruby-lang.org/issues/10845 ruby/ruby#3701
|
Looks good to me. |
|
Confirmed this pull request addresses the CI failure at https://buildkite.com/rails/rails/builds/72947#6a6a6523-71a1-4e64-9de2-597a161f0aaa |
amatsuda
added a commit
that referenced
this pull request
Dec 1, 2020
Let AS::SafeBuffer#[] and * return value be an instance of SafeBuffer in Ruby 3.0
amatsuda
added a commit
that referenced
this pull request
Dec 1, 2020
Let AS::SafeBuffer#[] and * return value be an instance of SafeBuffer in Ruby 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ruby 3 introduces an incompatibility that all String methods return String instances when called on a subclass instance.
https://bugs.ruby-lang.org/issues/10845
ruby/ruby#3701
This slightly affects our ActiveSupport::SafeBuffer that subclasses String, and here's a patch for
SafeBuffer#[]andSafeBuffer#*to preserve Ruby 2 behavior (= return another SafeBuffer instance) in Ruby 3.Note that almost all other methods that were changed in Ruby 3.0 were overridden on SafeBuffer to return a String already, so only two methods here were needed to be patched for the tests to pass.