Allow access to CurrentAttributes in test teardown #40588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using CurrentAttributes in tests, they get reset before teardown.
It's annoying when you use multiple setup/teardown in different places and expect to be able to use CurrentAttributes.
For example:
Since the test helper helps to prevent leaks, it can call
reset_all
at the very end of teardown, inafter_teardown
, after the call tosuper
.@rafaelfranca
cc @byroot