Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate how to use Relation#merge in Join Table conditions [ci skip] #40096

Merged

Conversation

danielricecodes
Copy link
Contributor

@danielricecodes danielricecodes commented Aug 23, 2020

Summary

The current Active Record Querying guide, Section "Specifying Conditions on the Joined Tables", is missing an example showing how to use Relation#merge.

The existing examples are sufficient to generate relatively basic join table conditions; however, Relation#merge must be used to generate advanced SQL queries or to use existing named scopes.

Other Information

This PR is only for documentation.

@rails-bot rails-bot bot added the docs label Aug 23, 2020
@danielricecodes danielricecodes force-pushed the update-active-record-querying-guide branch from a61b70b to 9bd8575 Compare August 27, 2020 16:36
@vipulnsward vipulnsward self-assigned this Aug 29, 2020
guides/source/active_record_querying.md Outdated Show resolved Hide resolved
guides/source/active_record_querying.md Outdated Show resolved Hide resolved
danielricecodes and others added 2 commits September 7, 2020 22:08
Co-authored-by: Petrik de Heus <petrik@deheus.net>
Co-authored-by: Petrik de Heus <petrik@deheus.net>
@rails-bot
Copy link

rails-bot bot commented Dec 7, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Dec 7, 2020
@danielricecodes
Copy link
Contributor Author

@p8 - can this PR be reviewed and merged??

@rails-bot rails-bot bot removed the stale label Dec 7, 2020
@rafaelfranca rafaelfranca merged commit 257f151 into rails:master Dec 9, 2020
rafaelfranca added a commit that referenced this pull request Dec 9, 2020
…g-guide

Demonstrate how to use Relation#merge in Join Table conditions  [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants