Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module.parent: NoMethodError for String#squish #39042

Closed
sshaw opened this issue Apr 25, 2020 · 2 comments
Closed

Module.parent: NoMethodError for String#squish #39042

sshaw opened this issue Apr 25, 2020 · 2 comments

Comments

@sshaw
Copy link
Contributor

sshaw commented Apr 25, 2020

Deprecation warning uses it. It lives in active_support/core_ext/string/filters.rb but it's never required.

Steps to reproduce

~/code/ruby/class2 >ruby -ractive_support/version -e'p ActiveSupport.version'
#<Gem::Version "6.0.2.2">

~/code/ruby/class2 >ruby -ractive_support/core_ext/module -e'Module.new.parent_name'
Traceback (most recent call last):
	1: from -e:1:in `<main>'
/Users/sshaw/.rvm/gems/ruby-2.5.2/gems/activesupport-6.0.2.2/lib/active_support/core_ext/module/introspection.rb:20:in `parent_name': undefined method `squish' for #<String:0x00007fbd819c8510> (NoMethodError)

Expected behavior

Deprication warning

Actual behavior

NoMethodError

System configuration

Rails version: NA

Ruby version: 2.5.2

@sshaw
Copy link
Contributor Author

sshaw commented Apr 25, 2020

This applies to Module.parent and Module.parent_name

@fxn fxn closed this as completed in 358ac36 Apr 25, 2020
@fxn
Copy link
Member

fxn commented Apr 25, 2020

Thanks!

fxn added a commit that referenced this issue Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants