Fix escaping in OptimizedFileSystemResolver #37119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
reviewed
Sep 9, 2019
`OptimizedFileSystemResolver` builds a regular expression to match view template paths. Prior to this patch, only file globbing special characters were escaped when building this regular expression, leaving other regular expression special characters unescaped. This patch properly escapes all regular expression special characters, and adds test coverage for paths that include these characters. Fixes rails#37107.
jonathanhefner
force-pushed
the
fix-escaping-in-view-path-resolver
branch
from
18100e0
to
897cdc7
Compare
|
@jhawthorn Thank you for the review! I've made the suggested change. |
eugeneius
pushed a commit
that referenced
this pull request
Mar 22, 2020
…th-resolver Fix escaping in OptimizedFileSystemResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptimizedFileSystemResolverbuilds a regular expression to match view template paths. Prior to this patch, only file globbing special characters were escaped when building this regular expression, leaving other regular expression special characters unescaped.This patch properly escapes all regular expression special characters, and adds test coverage for paths that include these characters.
Fixes #37107.