Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise TypeError instead of infinite loop in resolve_connection #36848

Merged
merged 1 commit into from Aug 7, 2019

Conversation

jhawthorn
Copy link
Member

I think this line was previously untested, which did no harm until I made a mistake and passed it the wrong type 😅.

@eileencodes
Copy link
Member

@jhawthorn you can also backport this to 6-0-stable.

@jhawthorn jhawthorn added this to the 6.0.0 milestone Aug 7, 2019
@jhawthorn jhawthorn merged commit ec2dcdd into rails:master Aug 7, 2019
jhawthorn added a commit to jhawthorn/rails that referenced this pull request Aug 9, 2019
…onnection

Raise TypeError instead of infinite loop in resolve_connection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants