Patch load error in case GemSpecError #34557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I stumbled upon this error while trying to make a basic.
And it gave out a:
It seems that I was missing a dependency (sqlite3 sigh) , and Gem
MissingSpecError
has some problems here in initialisation -- it requires 2 arguments .I replicated the offending line:
It seems like
LoadError
also catchesMissingSpecError
. The last one requires 2 arguments, and fails to provide a meaningful error message. -- http://ruby-doc.org/stdlib-2.4.0_preview1/libdoc/rubygems/rdoc/Gem/MissingSpecError.htmlIn this PR we would be casting that error to a
LoadError
instead when rescuing and re-raising aMissingSpecError
(since we would need more complex arguments)The alternative would be to create some convoluted logic for handling these 2 types of exceptions