Fix ArgumentError when uploading to amazon s3

[mogulla3]

Summary

I fixed lack of modification the following commit.
54ed6ad

In rails 5.2.1.1, when I uploaded object using #attach to amazon s3, ArgumentError: unknown keyword: content_type was occurred.

[gmcgibbon]

Thanks for fixing this!

[eileencodes]

Backported to 5-2-stable in a69b5b1

[jhaber1]

Any chance this gets released as 5.2.1.2 any time soon?

[rafaelfranca]

No. You are free to use the 5-2-stable branch.

[eileencodes]

Commenting because some folks have reached out to me to ask why we're not releasing a 5.2.1.2

To clarify what Rafael means is we are releasing 5.2.2 v soon and that will include the bug fix. Building the gem from 5-2-stable is also a viable in the meantime.

[rafaelfranca]

There is three costs of releasing a security fix version:

• maintainer overhead - it is very stressful and full of manual steps and verifications to release a security fix version.
• psychologic pressure - because it is a security release people think they need to upgrade ASAP.
• time pressure - The release needs to be done ASAP.

Since this is fixing a bug I'd prefer to release this in a bug fix release without of those costs. Bundler is here to help everyone. There is no reason why you can't use the 5-2-stable branch, it contains the same code that would be contained in the 5.2.2 release.

That being said, I'm planning to do a release, but not because of this issue and with no time commitment.

[spohlenz]

@rafaelfranca Any chance of updating the post at https://weblog.rubyonrails.org/2018/11/27/Rails-4-2-5-0-5-1-5-2-have-been-released/ with a note about this issue? I spent a while this morning tracking down this issue in one of my apps before finding this PR and I dare say others will experience the same.

[rafaelfranca]

5.2.2.rc1 was released just to address this issue. I can update the blog post for the new release with that information.

[kugaevsky]

@rafaelfranca did you have in mind that you're breaking all third-party active storage services implementations by changing Service#upload ActiveStorage API call?
For example, chaadow/activestorage-openstack and others.

Maybe it's better to revert this change before pulling it in 5.2.2 and find another way of hacking this feature?

[chaadow]

@kugaevsky Just saw your comment by accident, I'm going to fix this and my gem altogether with the most recent fog-openstack version. Thank you.

[kugaevsky]

@chaadow thank you.

[aliammaar]

is there anyone else around still getting this error at rails 5.2.3 and ruby 2.
4.0?