Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to ActiveModel#numericality in 5.2.1 break ActiveAttr #33686

Closed
edzhelyov opened this issue Aug 22, 2018 · 0 comments
Closed

Changes to ActiveModel#numericality in 5.2.1 break ActiveAttr #33686

edzhelyov opened this issue Aug 22, 2018 · 0 comments

Comments

@edzhelyov
Copy link

Steps to reproduce

Gist with runnable code

After the changes in fe9547b the tests from the gist started to fail in my project.
While the PR #33654 attempts to fix other regressions it won't fix the issues with ActiveAttr.

The specs will pass if we remove the type: Integer cast from the attributes, so it's related to the type cast ActiveAttr makes I assume, but haven't dig dipper into both ActiveModel changes and ActiveAttr code.

I'm including @cgriego (the ActiveAttr's author) as he might have suggestions.

/cc @kamipo

System configuration

Rails version: 5.2.1

Ruby version: 2.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant