ActiveRecord errors while handling error without Bundler

[JoshCheek]

Synopsis

When running ActiveRecord, it tries to require the adapter. When requiring the adapter fails, it catches the error message and tries to reraise it with a helpful error explaining that you need to install the gem. When Bundler is loaded, it calls the methods that Bundler monkey patches, which raises a Gem::LoadError, and everything works. However, without Bundler, the non-monkey patched version is called, which raises a Gem::MissingSpecError. These aren't compatible because they are initialized differently:

Gem::LoadError.instance_method(:initialize).parameters
# => [[:rest]]

Gem::MissingSpecError.instance_method(:initialize).parameters
# => [[:req, :name], [:req, :requirement]]

So, when ActiveRecord tries to reraise it (here), it explodes.

I've also reported this to Bundler here. There's a bit more analysis there, I'd reproduce it here, but my cat is interfering with my typing.

Steps to reproduce

Invoke bash run.sh from this gist.

Expected behavior

An error with the message "Error loading the 'sqlite3' Active Record adapter. Missing a gem it depends on? sqlite3 is not part of the bundle. Add it to your Gemfile."

Actual behavior

An error with the message "wrong number of arguments (given 1, expected 2)"

System configuration

ActiveRecord version: 5.2.0
Ruby version: 2.5.0
Rubygems version: 2.7.6
Rubygems version: 1.16.1

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 5-2-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

[JoshCheek]

• I can still reproduce this error on master.
• @y-yagi's PR, Consolidate errors when loading adapter gem fails into LoadError #32850 fixes it, but IDK, they forgot to merge it or something.
• I've updated the gist to show that it is still broken on master but is now fixed on y-yagi:fixes_32830

[JoshCheek]

I don't seem to have a reopen button.

[JoshCheek]

❤️s for @rafaelfranca!!

[y-yagi]

Fixed by #34557.