fixes a javascript bug in ActiveStorage that broke direct uploads in IE11

[kylekeesling]

Summary

Direct upload was throwing an error after the assets were uploaded to a service, specifically when attempting to set the css style to none.

More background and info is outlined in #32378 and my first attempt at a PR #32454

Fixes #32378

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[kylekeesling]

FYI @javan

[javan]

Can you update your rails fork with rails master, please? I believe your compiled activestorage.js is missing the most recent changes to the src files.

[kylekeesling]

OK - I think I did what you needed. Thanks for bearing with me, I'm out of my element with some of this git stuff :)

[javan]

All good! We're back in the same boat with your commits needing squashing again. Want to practice? http://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#iterate-as-necessary

[javan]

The goal is to have a single commit with your fix both in src/ and the compiled activestorage.js.

[kylekeesling]

Woo boy was that fun.... ;)

I think that I got it all figured out. It looks like the source line is updated and the compiled activestorage.js contains the updated command e.style.display="none" as opposed to the old e.style="display:none"

I know this is a small tweak but this has been pretty cool for as it's my first PR to Rails. Thanks for the help!

[javan]

Great job! Thank you for fixing this and congrats on landing your first Rails commit!