From 715d6bc4d0ce953a4c53ac51d084db587be8ecc1 Mon Sep 17 00:00:00 2001 From: Josh Goodall Date: Mon, 21 Sep 2020 16:34:37 +1000 Subject: [PATCH] test case to illustrate isolated engine inheritance issue --- railties/test/railties/engine_test.rb | 29 ++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/railties/test/railties/engine_test.rb b/railties/test/railties/engine_test.rb index b6548660318fd..f397070e24d24 100644 --- a/railties/test/railties/engine_test.rb +++ b/railties/test/railties/engine_test.rb @@ -644,7 +644,7 @@ class Engine < ::Rails::Engine assert_equal Rails.application.routes, env["action_dispatch.routes"] end - test "isolated engine should include only its own routes and helpers" do + test "isolated engine routes and helpers are isolated to that engine" do @plugin.write "lib/bukkits.rb", <<-RUBY module Bukkits class Engine < ::Rails::Engine @@ -729,6 +729,30 @@ def polymorphic_path_without_namespace end RUBY + @plugin.write "app/controllers/bukkits/session_controller.rb", <<-RUBY + module Bukkits + class SessionController < ApplicationController + def index + render plain: default_path + end + + private + def default_path + foo_path + end + end + end + RUBY + + controller "bar", <<-RUBY + class BarController < Bukkits::SessionController + private + def default_path + bar_path + end + end + RUBY + @plugin.write "app/mailers/bukkits/my_mailer.rb", <<-RUBY module Bukkits class MyMailer < ActionMailer::Base @@ -746,6 +770,9 @@ class MyMailer < ActionMailer::Base assert ::Bukkits::MyMailer.method_defined?(:foo_url) assert_not ::Bukkits::MyMailer.method_defined?(:bar_url) + get("/bar") + assert_equal "/bar", last_response.body + get("/bukkits/from_app") assert_equal "false", last_response.body