Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / improve tests #66

Merged
merged 3 commits into from May 12, 2017
Merged

Fix / improve tests #66

merged 3 commits into from May 12, 2017

Conversation

fschwahn
Copy link
Contributor

@fschwahn fschwahn commented May 5, 2017

Hi,
I addressed #65 and noticed that some tests are failing. The tests fail because nokogiri behavior changed slightly. Tests still pass with 1.6.6.2, and fail at least since 1.6.8.1 (I didn't check which exact nokogiri release changed this behavior because I think it doesn't matter.). What changed in Nokogiri was that multiple opening tags are no longer removed, but escaped. Example:

before:

full_sanitize("<<<a>") # => ""

after:

full_sanitize("<<<a>") # => "&lt;&lt;"

I adjusted the tests so they pass again.

Lastly, I fixed a deprecation warning from MiniTest.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@fschwahn
Copy link
Contributor Author

fschwahn commented May 5, 2017

CI failure is unrelated to this PR, it's because rubinius couldn't be installed. Maybe it should be added to allowed failures?

@kaspth kaspth merged commit 9057f42 into rails:master May 12, 2017
@kaspth
Copy link
Contributor

kaspth commented May 12, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants