Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CI service #123

Closed
fxn opened this issue Oct 28, 2018 · 5 comments
Closed

Change CI service #123

fxn opened this issue Oct 28, 2018 · 5 comments

Comments

@fxn
Copy link
Member

fxn commented Oct 28, 2018

CircleCI runs the test suite when we merge to master, but apparently as of this writing CircleCI does not support checking PRs.

Guess we have to switch to Travis? What do you think @yhirano55?
@rafaelfranca
Copy link
Member

rafaelfranca commented Nov 15, 2018 •
edited

That is strange. We used circle CI at Shopify and I'm sure it runs builds on PRs. Is not any configuration missing?

@rafaelfranca
Copy link
Member

Ah, rack also uses circle CI and all PRs have builds for circle CI. rack/rack#1314

@fxn
Copy link
Member Author

fxn commented Nov 15, 2018

Sure I have missed some documentation.

@osis
Copy link

osis commented Jan 22, 2019 •
edited

Just an FYI that I'm using this repo as a rails example for the Concourse CI docs. Would mind using it for a Pull Request example as well if the need is there.

@rafaelfranca
Copy link
Member

I fixed this issue on Circle CI some months ago and forgot to close it. We don't need to change CIs anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fxn @rafaelfranca @osis