Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unescape_js to match changes in Action View #269

Merged
merged 1 commit into from Mar 30, 2020
Merged

Fix unescape_js to match changes in Action View #269

merged 1 commit into from Mar 30, 2020

Conversation

repinel
Copy link
Member

@repinel repinel commented Mar 30, 2020

Unescapes dollar signs and backticks added by rails/rails@033a738

@repinel
Fix unescape_js to match changes in Action View
b6d6e25 
Unescapes dollar signs and backticks added by rails/rails@033a738
@kaspth kaspth merged commit 6361d43 into rails:master Mar 30, 2020
@kaspth
Copy link
Contributor

kaspth commented Mar 30, 2020

Good idea, thanks!

@repinel
Copy link
Member Author

repinel commented Mar 30, 2020

Thanks, Kasper! 😄

@repinel repinel deleted the fix-unescape-js branch March 30, 2020 20:53
@repinel
Copy link
Member Author

repinel commented Apr 10, 2020

@kaspth would it be possible to release this change?

@carlosantoniodasilva
Copy link
Member

@repinel released v4.4.0 including this change, thanks!

@repinel
Copy link
Member Author

repinel commented May 8, 2020

Thanks!

@kaspth
Copy link
Contributor

kaspth commented May 8, 2020

Ah, forgot about this, sorry. Thanks @carlosantoniodasilva 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@repinel @kaspth @carlosantoniodasilva