Migrate to GitHub actions and fixes various issues #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
github-actions
branch
from
377c925
to
2af3225
Compare
pixeltrix
approved these changes
May 7, 2021
This was referenced May 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit logs should explain what changed. The non obvious ones:
therubyracerno longer compile on newer rubies, and is no longer maintained. So I removed it.nodewas hanging in the Babel test, probably because of some event handler, regardless we can simply explictly exit.jscchanged path on modern macOS.GitHub Actions should also allow us to test windows, however it's currently fully broken because of some encoding issue, and I'd rather not go down this rabbit hole.