Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to EIP-1559 transactions #7313

Open
ulope opened this issue Aug 23, 2021 · 2 comments
Open

Switch to EIP-1559 transactions #7313

ulope opened this issue Aug 23, 2021 · 2 comments

Comments

@ulope
Copy link
Collaborator

ulope commented Aug 23, 2021

Abstract

Once full web3.py support for 1559 txs has landed we should start using it.
This will (hopefully) make our gas price calculations more predictable and also lower user gas costs.

Also see #7095
Blocked by: ethereum/web3.py#2066

Specification

TBD

Backwards Compatibility

N/A

@karlb
Copy link
Contributor

karlb commented Jan 6, 2022

The blocking issue is done. How would we set the new fee components? Can we do that reasonably without some kind of fee oracle?

@karlb
Copy link
Contributor

karlb commented Apr 14, 2022

We should remove the gas_price_strategy, since the web3py docs say

Gas price strategy is only supported for legacy transactions. The London fork introduced maxFeePerGas and maxPriorityFeePerGas transaction parameters which should be used over gasPrice whenever possible.

There is no progress on the fee oracle issue, so we'll have to decide on how to set maxFeePerGas and maxPriorityFeePerGas ourselves (or just leave them at the defaults). Any suggestions?

@taleldayekh taleldayekh assigned karlb and andrevmatos and unassigned karlb Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants