Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RxJS@7 deprecations #3097

Open
andrevmatos opened this issue Apr 4, 2022 · 0 comments
Open

Fix RxJS@7 deprecations #3097

andrevmatos opened this issue Apr 4, 2022 · 0 comments
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers refactor sdk 🖥
Milestone

Comments

@andrevmatos
Copy link
Contributor

andrevmatos commented Apr 4, 2022

Description

The latest major RxJS version is 7, which we're using, but they've recently merged a few deprecations in order to simplify their operator's set taking effect mostly on future RxjS@9, which is long in the future. Nonetheless, it's sane for us to implement the deprecation's alternatives, as they're simple enough and mostly map 1:1 with our current usage.

e.g.:

mapTo(value), // to
map(() => value), // or
map(constant(value)), // lodash's constant

Acceptance criteria

  • No more RxJS deprecation's warnings on codebase

Tasks

  • [ ]

Why do this?

Deprecated operator functions can be replaced with other functions to ensure future compatibility.

@andrevmatos andrevmatos added sdk 🖥 refactor dependencies Pull requests that update a dependency file labels Apr 4, 2022
@andrevmatos andrevmatos added this to the Tech Debt milestone Apr 4, 2022
@andrevmatos andrevmatos added the good first issue Good for newcomers label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers refactor sdk 🖥
Projects
None yet
Development

No branches or pull requests

1 participant