Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Tree #732

Open
2 tasks
antonreshetov opened this issue Mar 7, 2024 · 11 comments · May be fixed by #976
Open
2 tasks

[Feature]: Tree #732

antonreshetov opened this issue Mar 7, 2024 · 11 comments · May be fixed by #976
Labels
component New component suggestion

Comments

@antonreshetov
Copy link

Describe the feature

It would be nice to have a tree component.

Examples:

  1. https://element-plus.org/en-US/component/tree.html
  2. https://github.com/phphe/he-tree

Additional information

  • I intend to submit a PR for this feature.
  • I have already implemented and/or tested this feature.
@zernonia zernonia added the component New component suggestion label Mar 8, 2024
@sadeghbarati
Copy link
Contributor

@ChrisGV04
Copy link
Contributor

ChrisGV04 commented Mar 8, 2024

Maybe this can wait for Pragmatic Drag-and-Drop to launch the stable and documented v1. I imagine it's going to be amazing based on what I have seen from the developer behind it.

Check it out here: https://github.com/atlassian/pragmatic-drag-and-drop

@antonreshetov
Copy link
Author

Another good example, this is probably the closest I can think of to the concept

https://github.com/dgreene1/react-accessible-treeview

@alexreardon
Copy link

Pragmatic drag and drop is now public 🚀

@zernonia
Copy link
Collaborator

zernonia commented Apr 7, 2024

Yup @alexreardon ! Will start prototyping this component using Pragmatic dnd soon 😉

@zernonia zernonia linked a pull request May 28, 2024 that will close this issue
@zernonia
Copy link
Collaborator

zernonia commented Jun 4, 2024

Hey guys! I've started developing the component and I realized that draggable is not part of the spec for Tree View.

Thus we will not be including in the primitives. However, we will make sure to expose necessary API to make draggable possible and include an example 😁

@zernonia zernonia changed the title [Feature]: Draggable & Sortable Tree [Feature]: Tree Jun 4, 2024
@antonreshetov
Copy link
Author

@zernonia Do all components in radix implement the ARIA specification or only it?

The request was just so a complete tree component with drag & drop. There are many places where such functionality is needed, and if such a component were in radix it would add even more glory.

I also don’t think it was a good idea to rename the request title, it distorts the meaning.

@zernonia
Copy link
Collaborator

zernonia commented Jun 4, 2024

@antonreshetov yup all the components were built to handle and follow the ARIA specification. As dnd is not part of that, hence we are not planning to implement that, and most likely will not. However it with the dnd feature-request in mind, we will be sure to allow dev to build their own dnd using their favourite dnd package and desired behavior

@antonreshetov
Copy link
Author

antonreshetov commented Jun 4, 2024

Splitter is also ARIA?

@zernonia
Copy link
Collaborator

zernonia commented Jun 4, 2024

@antonreshetov
Copy link
Author

My message was different, ARIA is about accessibility, radix is ​​a set of components that simplify the development of interfaces. Is this the goal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component New component suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants