Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Upgrade to tokio v1.0 #1078

Closed
kim opened this issue Oct 20, 2020 · 4 comments · Fixed by #1463
Closed

Upgrade to tokio v1.0 #1078

kim opened this issue Oct 20, 2020 · 4 comments · Fixed by #1463
Assignees

Comments

@kim
Copy link
Contributor

kim commented Oct 20, 2020

Reminder that tokio v0.3.0 introduces cancellable JoinHandles, which would obsolete SpawnAbortable.

Other changes may or may not be compatible, and may or may not be immediate improvements.

@geigerzaehler
Copy link
Contributor

Since tokio v1 has been released we want to upgrade to that version.

@geigerzaehler geigerzaehler changed the title Upgrade to tokio v0.3.0 Upgrade to tokio v1.0 Jan 20, 2021
@FintanH
Copy link
Contributor

FintanH commented Jan 20, 2021

Depends on #1463 I believe.

@kim
Copy link
Contributor Author

kim commented Jan 25, 2021

Is there a good grasp on how much would break if upstream moved to tokio 1?

It looks like quinn merged their migration -- while link doesn't care much about tokio 1, that patch also includes moving to rustls 0.19, which we would benefit from (we need to use the exact same version of rustls as quinn). It is also that this was a major blocker for quinn to make a new official release, and it would be good to be able to move away from the pinned git dependency.

Due to the breaking nature of this migration, the question is how we want to coordinate it? Do we want to wait until #1463 lands, then make a coordinated effort to move both projects to tokio 1, then proceed with net/next? Or is it a small enough change to conflate it with either next or net/next?

@FintanH
Copy link
Contributor

FintanH commented Jan 25, 2021

Or is it a small enough change to conflate it with either next or net/next?

I could do a quick check on #1463 to see how much the compiler complains

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants