Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Regexp deprecated third argument with Regexp::NOENCODING #1998

Merged
merged 1 commit into from Dec 26, 2022

Conversation

weizheheng
Copy link
Contributor

Just upgraded to Ruby 3.2.0 and started seeing this deprecated warning message in my tests.

CleanShot 2022-12-26 at 12 05 33@2x

Related:

@ioquatix ioquatix force-pushed the fix-regexp-deprecated-third-argument branch from 6f5267f to 7877a35 Compare December 26, 2022 11:41
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ioquatix
Copy link
Member

ioquatix commented Dec 26, 2022

This was released in v2.2.5 and v3.0.3.

@ioquatix ioquatix self-assigned this Dec 26, 2022
tnir added a commit to rubygems/bundler-site that referenced this pull request Jan 1, 2023
See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir added a commit to rubygems/bundler-site that referenced this pull request Jan 1, 2023
See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
expressd3v added a commit to expressd3v/bundler-site that referenced this pull request Jan 13, 2023
See rack/rack#1998 for Ruby 3.2.0

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tenderlove added a commit that referenced this pull request Jan 17, 2023
* 3-0-sec: (24 commits)
  bump version
  Update changelog
  Fix ReDoS vulnerability in multipart parser
  Fix ReDoS in Rack::Utils.get_byte_ranges
  Forbid control characters in attributes
  Bump patch version.
  `Rack::Request#POST` should consistently raise errors. (#2010)
  Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH (#2007)
  Rack::MethodOverride handle QueryParser::ParamsTooDeepError (#2006)
  Bump patch version.
  Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998)
  Update tests to work on latest Rubies. (#1999)
  Bump patch version.
  Allow passing through streaming bodies. (#1993)
  Remove unnecessary executable bit from test files (#1992)
  Fix Utils.build_nested_query to URL-encode all query string fields (#1989)
  Trim trailing white space throughout the project (#1990)
  Fix some typos (#1991)
  Remove leading dot to fix compatibility with latest cgi gem. (#1988)
  Fix outdated Rack::Builder rdocs and remove Lobster references (#1986)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants