Fix respond_to?(:each) with Rack::Lint with streaming bodies.
#1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed fix in socketry/rack-conform#11 |
jeremyevans
requested changes
Nov 11, 2022
There was a problem hiding this comment.
to_ary and each handling looks correct. I can't see where to_path is implemented (there is verify_to_path, called by each). If you are going to add this, I think you should implement Wrapper#to_path, and have it call @body.to_path. Otherwise, if the body responds to to_path, Wrapper will say it responds to to_path when it doesn't, assuming I'm reading the code correctly.
jeremyevans
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last piece required to get webrick passing the conformance test suite with Rack 3.