Add rack.response_finished
to Rack::Lint
.
#1952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Rack::Lint to validate that
rack.response_finished
is anarray of callables when present in the
env
. e.g. procs, lambdas, orobjects that respond to
call
.This validates that:
rack.response_finished
is an arraycall
And specifies that:
(env, status, headers, error)
as arguments.Bringing #1802 to completion according to @tenderlove's recommendations/requirements.