Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation should note how to fix #2172

Closed
mperham opened this issue Apr 22, 2024 · 3 comments
Closed

Deprecation should note how to fix #2172

mperham opened this issue Apr 22, 2024 · 3 comments

Comments

@mperham
Copy link
Contributor

mperham commented Apr 22, 2024

def header
warn 'Rack::Response#header is deprecated and will be removed in Rack 3.1', uplevel: 1
headers
end

Please add "use headers instead" to the user message so the user knows how to fix the deprecation.

@ioquatix
Copy link
Member

Are you able to submit a PR? Thanks!

@mperham
Copy link
Contributor Author

mperham commented Apr 22, 2024

@ioquatix See #2173

@mperham mperham closed this as completed Apr 22, 2024
@ioquatix
Copy link
Member

Thanks Mike! Although small, this is a great improvement. Feel free to submit more PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants