Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leading dot to fix compatibility with latest cgi gem. #1988

Merged
merged 1 commit into from Nov 28, 2022

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Nov 28, 2022

This is now failing:

ArgumentError: invalid domain: ".test.com"
    /opt/hostedtoolcache/Ruby/3.0.5/x64/lib/ruby/3.0.0/cgi/cookie.rb:128:in `domain='
    /opt/hostedtoolcache/Ruby/3.0.5/x64/lib/ruby/3.0.0/cgi/cookie.rb:95:in `initialize'

@ioquatix ioquatix merged commit 3b5033b into main Nov 28, 2022
@ioquatix ioquatix deleted the fix-domain-leading-dot branch November 28, 2022 00:14
ioquatix added a commit that referenced this pull request Dec 26, 2022
tenderlove added a commit that referenced this pull request Jan 17, 2023
* 3-0-sec: (24 commits)
  bump version
  Update changelog
  Fix ReDoS vulnerability in multipart parser
  Fix ReDoS in Rack::Utils.get_byte_ranges
  Forbid control characters in attributes
  Bump patch version.
  `Rack::Request#POST` should consistently raise errors. (#2010)
  Fix Rack::Lint error message for HTTP_CONTENT_TYPE and HTTP_CONTENT_LENGTH (#2007)
  Rack::MethodOverride handle QueryParser::ParamsTooDeepError (#2006)
  Bump patch version.
  Fix Regexp deprecated third argument with Regexp::NOENCODING (#1998)
  Update tests to work on latest Rubies. (#1999)
  Bump patch version.
  Allow passing through streaming bodies. (#1993)
  Remove unnecessary executable bit from test files (#1992)
  Fix Utils.build_nested_query to URL-encode all query string fields (#1989)
  Trim trailing white space throughout the project (#1990)
  Fix some typos (#1991)
  Remove leading dot to fix compatibility with latest cgi gem. (#1988)
  Fix outdated Rack::Builder rdocs and remove Lobster references (#1986)
  ...
liuyangxy pushed a commit to fedora-riscv/ruby that referenced this pull request Jan 26, 2023
The original issue broke rubygem-actionpack:

rails/rails#46578
rails/rails#46595

rubygem-rack:

rack/rack#1988

And rack-test (where I have not checked details).
liuyangxy pushed a commit to fedora-riscv/ruby that referenced this pull request Jan 26, 2023
The original issue broke rubygem-actionpack:

rails/rails#46578
rails/rails#46595

rubygem-rack:

rack/rack#1988

And rack-test (where I have not checked details).
liuyangxy pushed a commit to fedora-riscv/ruby that referenced this pull request Jan 26, 2023
The original issue broke rubygem-actionpack:

rails/rails#46578
rails/rails#46595

rubygem-rack:

rack/rack#1988

And rack-test (where I have not checked details).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant