Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all non-standard handlers. #1584

Closed
ioquatix opened this issue Feb 9, 2020 · 8 comments
Closed

Remove all non-standard handlers. #1584

ioquatix opened this issue Feb 9, 2020 · 8 comments
Milestone

Comments

@ioquatix
Copy link
Member

ioquatix commented Feb 9, 2020

Thin seems like an interesting server, but if you look at the issue tracker, it has not been maintained for many years. The recent changes to the thin handler have caused issues (#1583).

I don't think we should be maintaining handlers for servers in rack. They should provide their own adapters. If the maintainer of thin is not wiling to do this, should we be on the hook for trying to maintain it within rack? Including version checks?

Here is what I think I'd willing to do.

1/ I want to remove the thin handler.

2/ I want to move that code to the thin repository.

3/ I want a new release of thin with this code.

@macournoyer what do you think? What should we do?

@ioquatix ioquatix added this to the v2.3.0 milestone Feb 9, 2020
@jeremyevans
Copy link
Contributor

I think in 2.3 we should deprecate handlers that require libraries not shipped with Ruby, and then remove such handlers in 3.0. The handlers that only use libraries that ship with Ruby (webrick and cgi) we can keep and fully test.

@ioquatix
Copy link
Member Author

ioquatix commented Feb 9, 2020

This was also the advice of @tenderlove, so I'm happy to agree with that.

@ioquatix ioquatix changed the title Future of thin Remove all non-standard handlers. Feb 9, 2020
@macournoyer
Copy link
Member

I think it make sense to remove the Thin handler from Rack. I agree handlers should be in the servers. I'd be happy to move the code to Thin and make a release.

@ioquatix ioquatix modified the milestones: v2.3.0, v3.0.0 Feb 10, 2020
@ioquatix
Copy link
Member Author

Should we move these handlers into separate repos, e.g. rack-fcgi or rack-handler-fcgi?

@jeremyevans
Copy link
Contributor

I don't think there is need to do that. We may want to reach out to the gem authors of the handlers and ask them to include the rack handler in their library if they want to support it. If not, users that want to continue using the handlers can copy the old version and maintain their own gem.

@ioquatix
Copy link
Member Author

While I can accept that position, I also wonder if anyone will bother to maintain rack-handler-fcgi or if we will be fracturing the users of such an interface. That being said, I don't think it matters a huge amount to me personally.

@ioquatix
Copy link
Member Author

I'm going to put this under the umbrella of #1593

@ioquatix
Copy link
Member Author

I'm working on this now. I don't think there will be a 2.3 release of rack.

ioquatix added a commit to ioquatix/rack that referenced this issue May 24, 2020
ioquatix added a commit to ioquatix/rack that referenced this issue May 24, 2020
stomar added a commit to stomar/rack that referenced this issue May 14, 2022
Only handlers for WEBrick and CGI are included with Rack,
the other handlers were removed.

See PR rack#1584, commit 98d9cf5
stomar added a commit to stomar/rack that referenced this issue May 14, 2022
Only handlers for WEBrick and CGI are included with Rack,
the other handlers were removed.

See PR rack#1584, commit 98d9cf5
stomar added a commit to stomar/rack that referenced this issue May 14, 2022
Only handlers for WEBrick and CGI are included with Rack,
the other handlers were removed.

See rack#1584, commit 98d9cf5.
ioquatix pushed a commit that referenced this issue May 14, 2022
Only handlers for WEBrick and CGI are included with Rack,
the other handlers were removed.

See #1584, commit 98d9cf5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants