Is SERVER_PORT required?

[ioquatix]

SERVER_PORT is required, so I would leave it in the check a few lines above. I do agree that we should check it is an integer.

Originally posted by @jeremyevans in #1561

Tests allow for it to be an empty string or not specified at all. The recent PR #1561 codifies this to Rack::Lint. Do we want to change this?

[jeremyevans]

As discussed, it may not make sense for unix sockets. So we may want to say it isn't required, but if set it must be an integer.

[ioquatix]

Implemented.

[ioquatix]

I reverted this. There were a ton of specs that provided a string containing an Integer.

I think we can revisit this for 3.0.

[ioquatix]

We made this optional in 2266e08

So the answer is, no. It must be nil or an Integer.