Call the correct accepts_html? method for prefer_plaintext #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Sep 13, 2018
Call the correct accepts_html? method for prefer_plaintext
rafaelfranca
added a commit
that referenced
this pull request
Sep 13, 2018
Call the correct accepts_html? method for prefer_plaintext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
prefers_plaintext?is calling a non-existentaccepts-htmlmethod. This was working in 1.5.x and looks like it changed starting in 1.6.x. We useprefers_plaintext?so we need this to make upgrading possible.Would it be possible to get this added into a 1.6.x release too? This PR is forked off of master so I'm happy to open another PR with a similar fix that's forked off of 1-6-stable (I wasn't sure the preferred way to do that).