Added (Unused) 306 HTTP Status Code #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I don't see what we gain by adding this. Could you expand on why you think we should? |
|
@matthewd the thought was that because it was denoted differently in the RFC from all of those that are unassigned, and that 306 is the only (unused) status code, that it might be useful to have there. |
|
Checked RFC, it's valid, and it's marked as literally "(Unused)" in exactly the same way all the other status codes are labeled, so for consistency and the other reasons stated above, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per RFC 7231 Section 6.4.6, I added Status Code 306. While it is unused, it is a reserved status code and unlike the other status codes that are not in this document, this was explicitly noted as unused and not unassigned making it a possible safeguard against people trying to use it for custom status codes (much like nginx does with 499 and 599).