should Rack::ContentLength close the body?

[lygaret]

Hey, I'm doing this as a discussion rather than an issue because I can't imagine I'm doing this right:

In Rack::ContentLength, the call method calls #to_ary on the body, but never calls #close.
Because of this, anything that uses the BodyProxy to run a block when the request is fully "sent" isn't getting done; I found it by noticing missing log lines from CommonLogger.

This seems like something that would screw other folk up though, so I'm curious, how are y'all handling that? Should the ContentLength middleware be calling #close? Is this just a middleware ordering problem on my end?

I've copied the middleware out to my own project and have added:

body.close if body.respond_to(:close)

just after the body is serialized, and it solved my issue -- is this worth submitting a PR for?

Thanks!

[lygaret]

Just found this:
#2062

Which makes me think that I'm just out of date...

[jeremyevans]

It's fixed in master, but it is not yet in any release.

[lygaret]

Perfect, thank you. I thought I was crazy.