From d710df59d0f78eb90f89786921c6cc28b9b2847f Mon Sep 17 00:00:00 2001 From: Samuel Williams Date: Thu, 6 Feb 2020 19:57:25 +1300 Subject: [PATCH] Relax requirement on HTTP_HOST as it breaks tests. --- lib/rack/lint.rb | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/rack/lint.rb b/lib/rack/lint.rb index 17e98ef72..1049cf281 100644 --- a/lib/rack/lint.rb +++ b/lib/rack/lint.rb @@ -286,13 +286,16 @@ def check_env(env) ## The SERVER_NAME must be a valid authority as defined by RFC7540. assert("env[SERVER_NAME] must be a valid host") do server_name = env["SERVER_NAME"] - URI.parse("http://#{server_name}").host == server_name rescue false + URI.parse("http://#{server_name}/").host == server_name rescue false end ## The HTTP_HOST must be a valid authority as defined by RFC7540. assert("env[HTTP_HOST] must be a valid host") do - http_host = env["HTTP_HOST"] - URI.parse("http://#{http_host}/").host == http_host rescue false + if http_host = env["HTTP_HOST"] + URI.parse("http://#{http_host}/").host == http_host rescue false + else + true + end end ## The environment must not contain the keys