diff --git a/SPEC.rdoc b/SPEC.rdoc index 5d89e09fc..72a5d41f2 100644 --- a/SPEC.rdoc +++ b/SPEC.rdoc @@ -137,6 +137,7 @@ There are the following restrictions: set. PATH_INFO should be / if SCRIPT_NAME is empty. SCRIPT_NAME never should be /, but instead be empty. +rack.response_finished:: An array of callables run after the HTTP response has been sent. === The Input Stream diff --git a/lib/rack/constants.rb b/lib/rack/constants.rb index f084852aa..63fd0565a 100644 --- a/lib/rack/constants.rb +++ b/lib/rack/constants.rb @@ -52,6 +52,7 @@ module Rack RACK_RECURSIVE_INCLUDE = 'rack.recursive.include' RACK_MULTIPART_BUFFER_SIZE = 'rack.multipart.buffer_size' RACK_MULTIPART_TEMPFILE_FACTORY = 'rack.multipart.tempfile_factory' + RACK_RESPONSE_FINISHED = 'rack.response_finished' RACK_REQUEST_FORM_INPUT = 'rack.request.form_input' RACK_REQUEST_FORM_HASH = 'rack.request.form_hash' RACK_REQUEST_FORM_VARS = 'rack.request.form_vars' diff --git a/lib/rack/lint.rb b/lib/rack/lint.rb index 0f67f2965..ea99a215b 100755 --- a/lib/rack/lint.rb +++ b/lib/rack/lint.rb @@ -359,6 +359,15 @@ def check_environment(env) unless env[SCRIPT_NAME] != "/" raise LintError, "SCRIPT_NAME cannot be '/', make it '' and PATH_INFO '/'" end + + ## rack.response_finished:: An array of callables run after the HTTP response has been sent. + if callables = env[RACK_RESPONSE_FINISHED] + raise LintError, "rack.response_finished must be an array of callable objects" unless callables.is_a?(Array) + + callables.each do |callable| + raise LintError, "rack.response_finished values must respond to call" unless callable.respond_to?(:call) + end + end end ## diff --git a/test/spec_lint.rb b/test/spec_lint.rb index 0b87b188a..d9f2c2b2d 100755 --- a/test/spec_lint.rb +++ b/test/spec_lint.rb @@ -209,6 +209,16 @@ def obj.error(*) end Rack::Lint.new(nil).call(env("SCRIPT_NAME" => "/")) }.must_raise(Rack::Lint::LintError). message.must_match(/cannot be .* make it ''/) + + lambda { + Rack::Lint.new(nil).call(env("rack.response_finished" => "not a callable")) + }.must_raise(Rack::Lint::LintError). + message.must_match(/rack.response_finished must be an array of callable objects/) + + lambda { + Rack::Lint.new(nil).call(env("rack.response_finished" => [->{}, "not a callable"])) + }.must_raise(Rack::Lint::LintError). + message.must_match(/rack.response_finished values must respond to call/) end it "notice input errors" do @@ -708,4 +718,10 @@ def assert_lint(*args) }).call(env({}))[1]['rack.hijack'].call(StringIO.new).read.must_equal '' end + it "pass valid rack.response_finished" do + Rack::Lint.new(lambda { |env| + [200, { "rack.response_finished" => [-> {}, lambda {}], "Content-length" => "3" }, ["foo"]] + }).call(env({})).first.must_equal 200 + end + end