Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support :mulitpart env key to env_for to force multipart input #303

Merged
merged 1 commit into from Jun 1, 2022

Conversation

jeremyevans
Copy link
Contributor

No description provided.

@bjeanes
Copy link

bjeanes commented May 27, 2022

What do you think about this defaulting this to check if ENV['CONTENT_TYPE'] is "multipart/form-data" or starts with "multipart/"?

@bjeanes
Copy link

bjeanes commented May 27, 2022

I have successfully implemented a proof-of-concept integration with this multipart key and opened a PR teamcapybara/capybara#2557.

It does seem to necessitate a change to the interfaces of the Driver#submit and Browser#submit methods, about which the Capybara maintainers may have reservations.

@jeremyevans
Copy link
Contributor Author

What do you think about this defaulting this to check if ENV['CONTENT_TYPE'] is "multipart/form-data" or starts with "multipart/"?

That seems reasonable to me, so I've updated the PR to do that.

@jeremyevans jeremyevans merged commit 5b4bbff into rack:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants