Add support for :query_params to set query parameters for non-GET requests #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uests This allows you to set both body parameters (:params) and query parameters (:query_params) for non-GET requests. For consistency, GET requests also support :query_params. If both :params and :query_params are provided, :params will append to the existing query before :query_params. Implements rack#150.
Rubocop will probably be ripped out completely in the future, but for right now, just disable the rules that are complaining.
This was referenced May 2, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to set both body parameters (:params) and query
parameters (:query_params) for non-GET requests.
For consistency, GET requests also support :query_params. If both
:params and :query_params are provided, :params will append to the
existing query before :query_params.
Implements #150.