Avoid create multiple large copies of uploaded file data in memory #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UploadedFile#append_to(buffer), to append to the given buffer in chunks using readpartial with an outbuf, rewinding the tempfile before and after (the tempfile that UploadedFile creates should always be seekable). Switch Utils.build_file_part to use this method. This should result in a general decrease in memory usage for large files, and the rewinding fixes rack#261. This uses the updated spec from rack#268. Co-authored-by: Jeremy Evans <code@jeremyevans.net>
|
This looks okay to me but I wonder if we should be using IO.copy_stream? |
We aren't copying from an IO to an IO, or I would have used that. I don't think IO.copy_stream support copying from an IO and appending to a string, it treats a string given as a filename, according to the documentation. |
|
@jeremyevans As for the "pointless cop demands" comment, I think it's fine by me to tweak the Rubcop config (or even disable Rubocop altogether for the project) as you see fit. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UploadedFile#append_to(buffer), to append to the given buffer
in chunks using readpartial with an outbuf, rewinding the tempfile
before and after (the tempfile that UploadedFile creates should
always be seekable). Switch Utils.build_file_part to use this
method.
This should result in a general decrease in memory usage for
large files, and the rewinding fixes #261.
This uses the updated spec from #268.