Docs: Breaking change in 0.8.0 re: UploadedFile.new #209
Conversation
History.md
Outdated
| * Breaking Change | ||
| * In `UploadedFile.new`, when passing a `Pathname`, an additional argument | ||
| is now required (`original_filename`). Provide the new argument or | ||
| call `to_s` on your `Pathname`. |
There was a problem hiding this comment.
What is the error you get if you don't do this? Is it the nil error we are seeing in #207?
There was a problem hiding this comment.
The error message is "Missing original_filename for IO". It comes from initialize_from_io.
def initialize_from_io(io, original_filename)
@tempfile = io
@original_filename = original_filename || raise(ArgumentError, 'Missing `original_filename` for IO')
end
There was a problem hiding this comment.
OK, interesting. There seems to be a couple of issues there, because people have also reported of nil error coming:
NoMethodError:
undefined method `size' for nil:NilClass
Could you update the text in line with this, so that this error is also listed there? Thanks a lot!
|
Based on the discussion in #207, it looks like this should be listed in the changelog under "Known Issue" rather than "Breaking Change". I will edit this PR accordingly. |
Updated, thanks. Hope it helps changelog-readers like myself :) |
Made it more factually correct.
|
Thanks @jaredbeck! I did a small tweak before mergin, hope that was OK. Pathname is technically not an IO object, it just "walks like one"... |
* Docs: Breaking change in 0.8.0 re: UploadedFile.new [ci skip] * Update History.md * Update History.md * Update History.md Made it more factually correct.
[ci skip]