Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer recovery retry needs to return the new consumer tag #680

Merged
merged 1 commit into from Apr 2, 2021
Merged

consumer recovery retry needs to return the new consumer tag #680

merged 1 commit into from Apr 2, 2021

Conversation

vikinghawk
Copy link
Contributor

Proposed Changes

The consumerRecoveryRetryOperation needs to make sure it is returning the new consumerTag so that it can get updated in AutorecoveringConnection.recoverConsumer(). This was previously not working as the last item in the chain (i.e. RECOVER_CONSUMER_QUEUE_BINDINGS) was always returning null. My previous PR that added RECOVER_PREVIOUS_CONSUMERS had the same issue. This should fix that.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@michaelklishin michaelklishin merged commit 9b7baa8 into rabbitmq:5.x.x-stable Apr 2, 2021
michaelklishin added a commit that referenced this pull request Apr 2, 2021
consumer recovery retry needs to return the new consumer tag

(cherry picked from commit 9b7baa8)
@michaelklishin
Copy link
Member

Forward-ported to master.

@vikinghawk vikinghawk deleted the consumerRecoveryRetryFix branch April 2, 2021 15:24
@acogoluegnes acogoluegnes added this to the 5.12.0 milestone Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants