Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable DNS resolution when using TLS #400

Closed
acogoluegnes opened this issue Aug 24, 2018 · 0 comments
Closed

Disable DNS resolution when using TLS #400

acogoluegnes opened this issue Aug 24, 2018 · 0 comments
Assignees
@acogoluegnes
Labels
effort-tiny usability
Milestone
4.8.0

Comments

@acogoluegnes
Copy link
Contributor

The client performs by default a DNS resolution when only one server address is provided. This is to enable DNS-based load-balancing, see #138. As stated in #138 (comment) it makes TLS hostname verification fail, because the hostname of the server certificate isn't likely to match the IP resolved by the DNS query.

For 4.x and 5.x, the client shouldn't use DNS resolution as soon as TLS is enabled. This would at least avoid making TLS troubleshooting even more difficult.

DNS resolution would then need to be explicitly set up as of 6.0.0.

References #138, #394.
@acogoluegnes acogoluegnes added this to the 4.8.0 milestone Aug 24, 2018
@acogoluegnes acogoluegnes self-assigned this Aug 24, 2018
@acogoluegnes acogoluegnes mentioned this issue Aug 24, 2018
Closed
acogoluegnes added a commit that referenced this issue Aug 27, 2018
@acogoluegnes
Disable DNS resolution when using TLS
ffd6b7d 
Fixes #400

(cherry picked from commit 8dde8b5)
acogoluegnes added a commit that referenced this issue Aug 27, 2018
@acogoluegnes
Adapt test to Java 6
6a5d962 
References #400
acogoluegnes added a commit that referenced this issue Aug 27, 2018
@acogoluegnes
Fix test method name
4277aee 
References #400

(cherry picked from commit 02164d7)

Conflicts:
	src/test/java/com/rabbitmq/client/test/ConnectionFactoryTest.java
acogoluegnes added a commit that referenced this issue Aug 27, 2018
@acogoluegnes
Disable DNS resolution when using TLS
8dde8b5 
Fixes #400
acogoluegnes added a commit that referenced this issue Aug 27, 2018
@acogoluegnes
Fix test method name
02164d7 
References #400
This was referenced Mar 16, 2021
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
effort-tiny usability
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
1 participant
@acogoluegnes