Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classes generated by codegen.py do not implement equals or hashcode #377

Closed
Woodz opened this issue Jul 5, 2018 · 0 comments
Closed

Classes generated by codegen.py do not implement equals or hashcode #377

Woodz opened this issue Jul 5, 2018 · 0 comments
Assignees
@acogoluegnes
Labels
effort-low usability
Milestone
4.8.0

Comments

@Woodz
Copy link

Woodz commented Jul 5, 2018

It would be very helpful if equals and hashcode could be implemented by the classes generated by codegen.py. The specific use case that has highlighted this issue is attempting to mock APIs that include AMQP.BasicProperties - even though the set of properties are identical, equality returns false, requiring a custom matcher to be implemented
@acogoluegnes acogoluegnes self-assigned this Aug 1, 2018
@acogoluegnes acogoluegnes added this to the 4.8.0 milestone Aug 1, 2018
acogoluegnes added a commit that referenced this issue Aug 16, 2018
@acogoluegnes
Add equals and hashCode to generate classes
9c13ded 
Fixes #377
@acogoluegnes acogoluegnes mentioned this issue Aug 16, 2018
Merged
acogoluegnes added a commit that referenced this issue Aug 16, 2018
@acogoluegnes
Add equals and hashCode to generate classes
22ca4c8 
Fixes #377
acogoluegnes added a commit that referenced this issue Aug 16, 2018
@acogoluegnes
Add equals and hashCode to generate classes
de907f0 
Fixes #377

(cherry picked from commit 22ca4c8)
acogoluegnes added a commit that referenced this issue Aug 16, 2018
@acogoluegnes
Add equals and hashCode to generate classes
6fced10 
Fixes #377

(cherry picked from commit 22ca4c8)
This was referenced Mar 16, 2021
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acogoluegnes acogoluegnes

Labels
effort-low usability
Projects
None yet
Milestone
4.8.0
Development

No branches or pull requests
2 participants
@acogoluegnes @Woodz