New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhelpful exception message when clientProvidedName is too long #980
Comments
@loop-evgeny would you mind providing an example of a message that is "too long"? Since this happens early during connection negotiation, the max frame size is not yet negotiated and so there is a default frame size that must be exceeded. Enforcing validation when the value is set is the only solution. |
If you mean what the client generates when I call CreateConnection - I don't know how to capture that. But it should be easy to repro the problem with the one-liner above. |
Just FTR, with most clients the best way to capture that value is to take a traffic capture. With some (Bunny, possibly others) a tracing mode of all outgoing protocol frames would be an easier alternative. |
RabbitMQ .NET client 6.1.2 on .NET Core 3.1, Windows 7
RabbitMQ Server 3.7.26, Erlang 22.2.8, Ubuntu 18.04
Try to create a connection with a
clientProvidedName
that's too long, like this:Expected results - either an exception message that tells me that the
clientProvidedName
is too long or theclientProvidedName
is automatically truncated to a usable length. (The latter is probably preferable: as I understand,clientProvidedName
is mostly used for troubleshooting, so most users would probably prefer for the connection to succeed.)Actual results - exception message that gives little clue as to what's wrong:
The server logs this:
... which is slightly more helpful - but not everyone has access to server logs.
The text was updated successfully, but these errors were encountered: