Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry Propagation #22

Closed
brianmori opened this issue Oct 15, 2021 · 3 comments
Closed

OpenTelemetry Propagation #22

brianmori opened this issue Oct 15, 2021 · 3 comments

Comments

@brianmori
Copy link

Hi,

I would like to ask if OpenTelemetry support should be part of this library.

When a service A communicate through rabbitmq to service B, service A needs to propagate the "TraceID" and "SpanID" to service B to measure the time needed.

I saw this issue which may help:
open-telemetry/opentelemetry-go-contrib#376

@Zerpet
Copy link
Contributor

Zerpet commented Oct 18, 2021

Hey there, by "support should be part of this library", I understand you would like to provide automatic instrumentation, something somewhat similar to e.g. Cassandra instrumentation?

@brianmori
Copy link
Author

Hi,
I would not add any exporter difference (eg. zipkin) as it is a component to be chosen by the dev team, rather only the propagator to inject TraceId, SpanId in the RabbitMQ headers.

I would avoid to add information to the payload as a checksum is needed in certain scenarios.

@DanielePalaia
Copy link
Contributor

There is a discussion to add support for Open Telemetry, but not a short term plan. Let's keep this Issue #43 to track the advancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants