Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMQP Spec #110

Merged
merged 1 commit into from Sep 1, 2022
Merged

Update AMQP Spec #110

merged 1 commit into from Sep 1, 2022

Conversation

Zerpet
Copy link
Contributor

@Zerpet Zerpet commented Aug 24, 2022

Adding missing constant 302 for no-route error.

The spec says that basic.recover should be async, but this breaks our
test TestIntegrationRecoverNotImplemented(). RabbitMQ has deprecated
this method and it will be removed in a future release. This commit also
adds a deprecation notice to channel.Recover().

Adding missing constant 302 for no-route error.

The spec says that `basic.recover` should be async, but this breaks our
test `TestIntegrationRecoverNotImplemented()`. RabbitMQ has deprecated
this method and it will be removed in a future release. This commit also
adds a deprecation notice to `channel.Recover()`.

Signed-off-by: Aitor Perez Cedres <acedres@vmware.com>
@Zerpet Zerpet added this to the 1.5.0 milestone Aug 24, 2022
@Zerpet Zerpet requested a review from lukebakken August 26, 2022 11:12
@lukebakken
Copy link
Contributor

I'm assuming this PR should also have the code to fix #107 in it as well?

spec091.go Show resolved Hide resolved
spec/gen.go Show resolved Hide resolved
spec/amqp0-9-1.stripped.extended.xml Show resolved Hide resolved
@Zerpet
Copy link
Contributor Author

Zerpet commented Aug 30, 2022

I'm assuming this PR should also have the code to fix #107 in it as well?

This commit is a pre-requisite to fix #107. I'll submit another PR for that one. I'm still doing some Q/A on that.

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Zerpet Zerpet merged commit 1d9c22a into main Sep 1, 2022
@Zerpet Zerpet deleted the update-amqp-spec branch September 1, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants