Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow use with importlib_metadata version 4 #7

Merged
merged 1 commit into from Feb 23, 2022

Conversation

Neki
Copy link
Contributor

@Neki Neki commented Feb 22, 2022

This change makes single-source compatible with more packages, as other
packages may require importlib_metadata version 4.

The only breaking change in version 4 is:

PackageMetadata as returned by metadata() and Distribution.metadata() now provides normalized metadata honoring PEP 566

which has no impact on single-source (from https://github.com/python/importlib_metadata/blob/main/CHANGES.rst).

This change makes single-source compatible with more packages, as other
packages may require importlib_metadata v4.

The only breaking change in version 4 is:

    PackageMetadata as returned by metadata() and Distribution.metadata() now provides normalized metadata honoring PEP 566

which has no impact on single-source.
@Neki
Copy link
Contributor Author

Neki commented Feb 22, 2022

Travis CI doesn't seem to run on this branch, but I ran the tests with pytest with the latest version and everything passed:

% poetry update
...
% pytest
============================================================================ test session starts =============================================================================
platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.0.0
rootdir: /home/benoit/terality/single-source
plugins: mock-3.6.1
collected 15 items

tests/test_regex.py .........                                                                                                                                          [ 60%]
tests/test_version.py ......                                                                                                                                           [100%]

============================================================================= 15 passed in 0.04s =============================================================================

@rabbit72
Copy link
Owner

That's a good idea. Thank you for contribution.

@rabbit72 rabbit72 merged commit 1e7426f into rabbit72:master Feb 23, 2022
@rabbit72
Copy link
Owner

rabbit72 commented Mar 8, 2022

It took longer to release due to my vacation. I have to migrate from travis ci I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants