Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JVS as Dataset #91

Closed
Aria-K-Alethia opened this issue Dec 10, 2019 · 9 comments
Closed

Support JVS as Dataset #91

Aria-K-Alethia opened this issue Dec 10, 2019 · 9 comments
Labels
dataset

Comments

@Aria-K-Alethia
Copy link
Contributor

Hi,

I wonder if you want to add JVS as a dataset, it is a Japanese Multi-speaker speech dataset.

If you want, I think I can write the code.
@r9y9
Copy link
Owner

r9y9 commented Dec 10, 2019

That would be great to have. Do you mind making a PR?

@Aria-K-Alethia
Copy link
Contributor Author

That would be great to have. Do you mind making a PR?

OK, no problem.

@Aria-K-Alethia
Copy link
Contributor Author

Have you see the PR ? I committed the code, but seems can not pass the testcode, I don't know the reason...

@r9y9
Copy link
Owner

r9y9 commented Dec 17, 2019

Sorry! I’ve been busy for a while. I’ll take a look once I get some time.

@r9y9 r9y9 added the dataset label Dec 21, 2019
@Aria-K-Alethia
Copy link
Contributor Author

Hi, I've fixed some of the inappropriate codes your mentioned, see it if you have time.

@Aria-K-Alethia
Copy link
Contributor Author

The code has been modified, however I don't know why the CI test failed again.

@r9y9
Copy link
Owner

r9y9 commented Jan 8, 2020

CI failure doesn't seem to be related to your changes. Let me see if it still persists after merging the PR.

@r9y9
Copy link
Owner

r9y9 commented Jan 8, 2020

note to self: better to update docs and changelogs as well. After that, I will close the issue.

@r9y9
Copy link
Owner

r9y9 commented Jan 8, 2020

CI failure seems related to nedbat/coveragepy#916

@r9y9 r9y9 closed this as completed in a011f55 Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dataset
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r9y9 @Aria-K-Alethia