-
-
Notifications
You must be signed in to change notification settings - Fork 1
/
rails_specific_action_name.rb
70 lines (61 loc) · 1.78 KB
/
rails_specific_action_name.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
# frozen_string_literal: true
module RuboCop
module Cop
module Sevencop
# Use only specific action names.
#
# It is good practice to separate controller classes rather than adding more actions as needed.
# By default, the 7 CRUD action names are specified that are generated by the Rails scaffold.
#
# @example
# # bad
# class UsersController < ApplicationController
# def articles
# end
# end
#
# # good
# class UserArticlesController < ApplicationController
# def index
# end
# end
class RailsSpecificActionName < Base
include VisibilityHelp
MSG = 'Use only specific action names.'
# @param node [RuboCop::AST::DefNode]
# @return [void]
def on_def(node)
return unless bad?(node)
add_offense(
node.location.name,
message: format(
'Use only specific action names (%<action_names>s).',
action_names: configured_action_names.join(', ')
)
)
end
private
# @param node [RuboCop::AST::DefNode]
# @return [Boolean]
def action?(node)
node_visibility(node) == :public
end
# @param node [RuboCop::AST::DefNode]
# @return [Boolean]
def bad?(node)
action?(node) &&
!configured_action_name?(node)
end
# @param node [RuboCop::AST::DefNode]
# @return [Boolean]
def configured_action_name?(node)
configured_action_names.include?(node.method_name.to_s)
end
# @return [Array<String>]
def configured_action_names
cop_config['ActionNames']
end
end
end
end
end