-
-
Notifications
You must be signed in to change notification settings - Fork 1
/
redundant_existence_check_spec.rb
115 lines (98 loc) · 3.31 KB
/
redundant_existence_check_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Sevencop::RedundantExistenceCheck, :config do
context 'with FileUtils.rm(a)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
FileUtils.rm(a) if FileTest.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.rm(a, force: true)
RUBY
end
end
context 'with FileUtils.rm(a, force: true)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
FileUtils.rm(a, force: true) if FileTest.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.rm(a, force: true)
RUBY
end
end
context 'with FileUtils.rm_f(a)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
FileUtils.rm_f(a) if FileTest.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.rm_f(a)
RUBY
end
end
context 'with File.delete(a)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
File.delete(a) if FileTest.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.rm_f(a)
RUBY
end
end
context 'with FileUtils.mkdir(a)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
FileUtils.mkdir(a) unless FileTest.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.mkdir_p(a)
RUBY
end
end
context 'with FileUtils.mkdir_p(a, verbose: true)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
FileUtils.mkdir_p(a, verbose: true) unless FileTest.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.mkdir_p(a, verbose: true)
RUBY
end
end
context 'with FileUtils.mkdir(a, verbose: true)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
FileUtils.mkdir(a, verbose: true) unless FileTest.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.mkdir_p(a, verbose: true)
RUBY
end
end
context 'with FileUtils.rm(a, force: true, verbose: true)' do
it 'autocorrects offense' do
expect_offense(<<~TEXT)
FileUtils.rm(a, force: true, verbose: true) if File.exist?(a)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid redundant existent check before file operation.
TEXT
expect_correction(<<~RUBY)
FileUtils.rm(a, force: true, verbose: true)
RUBY
end
end
context 'with different 1st argument' do
it 'registers no offense' do
expect_no_offenses(<<~TEXT)
FileUtils.mkdir(a) unless FileTest.exist?(b)
TEXT
end
end
end