Added agency and stop info to detailed itineraries #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wklumpen
changed the title
|
Need to add to the Detailed Itineraries docs and figure out why tests are failing here but not on my local machine |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
- Coverage 99.56% 99.49% -0.07%
==========================================
Files 35 35
Lines 1372 1386 +14
==========================================
+ Hits 1366 1379 +13
- Misses 6 7 +1 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Nov 1, 2023
|
To fix:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more detail to the transit portions of the detailed itineraries.
The main thing left to do here is generate the updated data column. @christophfink how did you go about that? It looks like a lot of the data is trimmed in a certain way; do you have a pattern for regenerating the test data?
See #361