Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black 23.1.0 introduces breaking changes #248

Closed
christophfink opened this issue Feb 1, 2023 · 1 comment · Fixed by #250
Closed

black 23.1.0 introduces breaking changes #248

christophfink opened this issue Feb 1, 2023 · 1 comment · Fixed by #250
Assignees
Labels
bug Something isn't working build system GitLab workflow does not work (or similar)

Comments

@christophfink
Copy link
Member

On the updated runners that use the python:3 docker image, our code does not pass linting, as black updated its style for 2023 last night. This has not yet arrived in conda, but is in pip (so the GitHub Action runners check for the new style)

see https://github.com/psf/black/releases/tag/23.1.0

this is the one that affects our code: psf/black#2945 , see https://github.com/r5py/r5py/actions/runs/4062655304/jobs/6994094010

@christophfink christophfink added bug Something isn't working build system GitLab workflow does not work (or similar) labels Feb 1, 2023
@christophfink christophfink added this to the Release v0.0.5 milestone Feb 1, 2023
@christophfink christophfink self-assigned this Feb 1, 2023
@christophfink
Copy link
Member Author

See also #249

@christophfink christophfink linked a pull request Feb 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build system GitLab workflow does not work (or similar)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant