Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GeneralName/GeneralNames #43

Open
reaperhulk opened this issue May 27, 2013 · 0 comments
Open

Refactor GeneralName/GeneralNames #43

reaperhulk opened this issue May 27, 2013 · 0 comments

Comments

@reaperhulk
Copy link
Member

These two classes are functional but ugly. I'm considering the following refactor (input appreciated):

Take R509::ASN1::GeneralName and refactor it into a base class. From that base class subclass each type I want to implement. (e.g. rfc822name, dnsname, directoryname, uri, and ip for now).

This would simplify each class and make them more easily testable. The tag to type and type to tag mappings might have to be rethought.

GeneralNames is really just a hash with a few helper methods for adding/accessing items + a serialization method. It may not need to change, but I'm listing it here as a reminder that a refactor touching GeneralName may open up a better way to do the GeneralNames object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant